Re: Improving deadlock error messages - Mailing list pgsql-hackers

From Neil Conway
Subject Re: Improving deadlock error messages
Date
Msg-id 1177365959.16415.170.camel@localhost.localdomain
Whole thread Raw
In response to Re: Improving deadlock error messages  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Improving deadlock error messages  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Mon, 2007-04-23 at 17:38 -0400, Tom Lane wrote:
> I'm really still opposed to the entire concept.  You're proposing to put
> a lot of fragile-looking code into a seldom-exercised error path.

There's certainly not a "lot" of code: the patch just adds a few
syscache lookups, wrapped in a PG_LOCK_NOWAIT() block.

As for fragility, I think the important point is whether it's safe to
siglongjmp() out of LockAcquire(); the rest is just window dressing.

-Neil




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Wild idea: 9.0?
Next
From: usleepless@gmail.com
Date:
Subject: Re: [pgsql-advocacy] Wild idea: 9.0?