Re: Improving deadlock error messages - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Improving deadlock error messages
Date
Msg-id 13821.1177364299@sss.pgh.pa.us
Whole thread Raw
In response to Re: Improving deadlock error messages  (Neil Conway <neilc@samurai.com>)
Responses Re: Improving deadlock error messages  (Neil Conway <neilc@samurai.com>)
Re: Improving deadlock error messages  (Jim Nasby <decibel@decibel.org>)
List pgsql-hackers
Neil Conway <neilc@samurai.com> writes:
> On Sat, 2007-04-21 at 19:43 -0400, Neil Conway wrote:
>> Attached is a very quick hack of a patch to do this.

> Does anyone have any feedback on this approach? If people are satisfied
> with this solution, I can get a cleaned up patch ready to apply shortly.

I'm really still opposed to the entire concept.  You're proposing to put
a lot of fragile-looking code into a seldom-exercised error path.
I fear bugs will survive a long time in there, and the net effect will be
that we get no information when we need it most.  The numeric printouts
may be ugly, but they are reliable.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "William Lawrance"
Date:
Subject: Re: [BUGS] BUG #3244: problem with PREPARE
Next
From: Josh Berkus
Date:
Subject: Re: [PATCHES] Full page writes improvement, code update