Re: XML changes broke assert-enabled vcbuild - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: XML changes broke assert-enabled vcbuild
Date
Msg-id 20070213154045.GA12830@svr2.hagander.net
Whole thread Raw
In response to XML changes broke assert-enabled vcbuild  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Tue, Feb 13, 2007 at 04:29:16PM +0100, Magnus Hagander wrote:
> The latest set of XML changes (I think latest, at least fairly recent)
> broke the win32vc build with asserts enabled. The line:
>     Assert(fully_escaped || !escape_period);
>
> From what I can tell, this is because the Assert() puts code (the do {}
> loop) *before* the declaration of StringInfoData buf, which is not
> permitted.
>
> Attached patch seems to fix this. Can someone confirm this is correct
> before I put it in?

I just realised I should of course move the comment as well :-) Thus,
the attached patch is more correct.

//Magnus


Attachment

pgsql-hackers by date:

Previous
From: "Pavan Deolasee"
Date:
Subject: Re: HOT for PostgreSQL 8.3
Next
From: Bruce Momjian
Date:
Subject: Re: Variable length varlena headers redux