XML changes broke assert-enabled vcbuild - Mailing list pgsql-hackers

From Magnus Hagander
Subject XML changes broke assert-enabled vcbuild
Date
Msg-id 20070213152916.GB11315@svr2.hagander.net
Whole thread Raw
Responses Re: XML changes broke assert-enabled vcbuild  (Magnus Hagander <magnus@hagander.net>)
Re: XML changes broke assert-enabled vcbuild  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: XML changes broke assert-enabled vcbuild  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
The latest set of XML changes (I think latest, at least fairly recent)
broke the win32vc build with asserts enabled. The line:
    Assert(fully_escaped || !escape_period);

>From what I can tell, this is because the Assert() puts code (the do {}
loop) *before* the declaration of StringInfoData buf, which is not
permitted.

Attached patch seems to fix this. Can someone confirm this is correct
before I put it in?

//Magnus


Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Variable length varlena headers redux
Next
From: Heikki Linnakangas
Date:
Subject: Re: Variable length varlena headers redux