Re: Variable length varlena headers redux - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Variable length varlena headers redux
Date
Msg-id 20070213150323.GA11315@svr2.hagander.net
Whole thread Raw
In response to Re: Variable length varlena headers redux  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Feb 13, 2007 at 09:44:03AM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Magnus Hagander wrote:
> >> Could the "new style" macros be back-ported to previous releases in case
> >> we do this?
> 
> > Yes, Tom and I talked about this.  It could appear in the next minor
> > release of all branches.
> 
> I don't really see the point of that.  Third-party authors who want
> their code to be backwards-compatible would do something like
> 
> #ifndef SET_VARLENA_LEN
> #define SET_VARLENA_LEN(var,len)  (VARATT_SIZEP(var) = (len))
> #endif
> 
> While we could provide this same macro in later updates of the current
> release branches, those authors are still going to want to include the
> above in their code so as to be able to compile against existing
> releases.  Therefore there's not really much point in us doing it too.

It'd be a help to those who wouldn't be building against releases with
known security issues in them for one ;-)

Sure, it's not important or a dealbreaker or so, but it would be
convenient.

//Magnus


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Foreign keys for non-default datatypes, redux
Next
From: Tom Lane
Date:
Subject: Re: Variable length varlena headers redux