Re: Problems with extended-Query logging code - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Problems with extended-Query logging code
Date
Msg-id 200609071526.k87FQHk11352@momjian.us
Whole thread Raw
In response to Re: Problems with extended-Query logging code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> I happened to notice that the recently added code to log Bind-message
> >> parameters was printing garbage into my log.  On investigation it turned
> >> out to be trying to print an already-pfree'd string.  That's fixable,
> 
> > Uh, can you show me where?
> 
> I didn't trace it down yet, but what I saw was garbage printed at
> Execute time in an assert-enabled build.  I think the bind-parameter
> string that's being saved in the portal for Execute to print is not
> copied into the portal's context.  Since I want to get rid of that bit
> anyway it didn't seem critical to identify the exact bug.

OK, thanks.  I thought I was doing that with a pstrdup(), but it might
have been in the wrong context at the time.  Thanks.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Problems with extended-Query logging code
Next
From: Martijn van Oosterhout
Date:
Subject: Re: Fixed length data types issue