Re: Problems with extended-Query logging code - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: Problems with extended-Query logging code
Date
Msg-id 20060907005646.GA28998@penne.toroid.org
Whole thread Raw
In response to Problems with extended-Query logging code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
At 2006-09-06 18:01:38 -0400, tgl@sss.pgh.pa.us wrote:
>
> That is, we'd log a Parse or Bind operation if it individually
> exceeded the duration threshold, and not otherwise.

Ok.

> If we've got support for logging the statement text and the parameter
> values at Execute time, isn't logging the preliminary steps just
> bloating the log?

Agreed. Logging Parse/Bind only if they're particularly interesting
sounds good to me.

> * I think that the best way to log bind-parameter values is to run the
> datatype output functions on the saved parameter values.  This works
> whether they were sent in text or binary mode, and avoids any extra
> overhead at Bind time that might not be repaid.

Great. (The logging of binary parameters is something I also... not
exactly _need_, but would be happy about.)

-- ams


pgsql-hackers by date:

Previous
From: Gavin Sherry
Date:
Subject: Re: Timezone List
Next
From: "Marc G. Fournier"
Date:
Subject: Re: gBorg status?