Re: Buildfarm owners: check if your HEAD build is stuck - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: Buildfarm owners: check if your HEAD build is stuck
Date
Msg-id 20060812214322.GA23000@svana.org
Whole thread Raw
In response to Buildfarm owners: check if your HEAD build is stuck  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Buildfarm owners: check if your HEAD build is stuck  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Sat, Aug 12, 2006 at 11:29:46AM -0400, Tom Lane wrote:
> What's happened is that that GUC patch that was in the tree for a few
> hours broke postmaster startup on some machines (for as-yet-unidentified
> reasons).  The postmaster does actually start and establish its
> lockfiles, but it never gets to the stage of being able to accept
> connections.

I don't know if it's related, but coverity just started picking up a
use-after-free in parse_value() in guc.c.

At the end of the switch (case PGC_STRING) there's a free(newval)
followed by an assignment of newval to retval->stringval a few lines
further down. They mark it as line 3956 of revision 1.335.

It may not be possible though, coverity is not omnicient.

Hope this helps,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: [PATCHES] extension for sql update
Next
From: Hannu Krosing
Date:
Subject: Re: [PATCHES] Forcing current WAL file to be archived