Re: Buildfarm owners: check if your HEAD build is stuck - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Buildfarm owners: check if your HEAD build is stuck
Date
Msg-id 200608131801.k7DI1bc07466@momjian.us
Whole thread Raw
In response to Re: Buildfarm owners: check if your HEAD build is stuck  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Martijn van Oosterhout wrote:
-- Start of PGP signed section.
> On Sat, Aug 12, 2006 at 11:29:46AM -0400, Tom Lane wrote:
> > What's happened is that that GUC patch that was in the tree for a few
> > hours broke postmaster startup on some machines (for as-yet-unidentified
> > reasons).  The postmaster does actually start and establish its
> > lockfiles, but it never gets to the stage of being able to accept
> > connections.
> 
> I don't know if it's related, but coverity just started picking up a
> use-after-free in parse_value() in guc.c.
> 
> At the end of the switch (case PGC_STRING) there's a free(newval)
> followed by an assignment of newval to retval->stringval a few lines
> further down. They mark it as line 3956 of revision 1.335.
> 
> It may not be possible though, coverity is not omnicient.

Yes, that was the area of the problem.  It has been redesigned.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: An Idea for planner hints
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Custom variable class segmentation fault