Re: note about syntax for fillfactor patch - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: note about syntax for fillfactor patch
Date
Msg-id 200607021629.k62GTtw08912@momjian.us
Whole thread Raw
In response to note about syntax for fillfactor patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> The latter seems seriously grotty: it forces the user to remember an

Agreed.

> I propose that we change the syntax to be
> 
>     WITH OIDS
>     | WITHOUT OIDS
>     | WITH (definition)
>     | /*EMPTY*/
> 
> and say that if you want to specify both OIDS and another option you
> have to write "oids" or "oids=false" in the definition list.
> 
> This gets rid of the hazard that someone might try to specify
> conflicting oids options in the hardwired part of the syntax and
> in the definition list, and lets the hardwired syntax be deprecated
> and perhaps someday removed.
> 
> Any objections?

Sounds good.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE
Next
From: Alvaro Herrera
Date:
Subject: Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE