Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE
Date
Msg-id 200607021624.k62GOvh08577@momjian.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Neil Conway wrote:
> Log Message:
> -----------
> Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
> the read lock we hold on the table's parent relation until commit.
> Update equalfuncs.c for the new field in AlterTableCmd. Various
> improvements to comments, variable names, and error reporting.
> 
> There is room for further improvement here, but this is at least
> a step in the right direction.

Thanks, that is what was needed.  The author obviously took the patch as
far as he could, and we needed to adjust his XXX areas, rather than not
apply the patch and have the code drifting.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: note about syntax for fillfactor patch
Next
From: Bruce Momjian
Date:
Subject: Re: note about syntax for fillfactor patch