Re: Error in recent pg_dump change (coverity) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Error in recent pg_dump change (coverity)
Date
Msg-id 20060528154248.GA11881@surnet.cl
Whole thread Raw
In response to Error in recent pg_dump change (coverity)  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: Error in recent pg_dump change (coverity)  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Error in recent pg_dump change (coverity)  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Martijn van Oosterhout wrote:
> Coverity picked up an error in dumpStdStrings() since last night. At
> line 1448 there's PQclear(res) yet it's used several times further down
> (lines 1452, 1454 and 1456).
>
> I'd actually suggest zeroing out res->tuples in PQclear so this sort of
> problem becomes much more obvious.

Is it worthwhile to zero out the res->block array as well?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment

pgsql-hackers by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: Error in recent pg_dump change (coverity)
Next
From: Tom Lane
Date:
Subject: Re: osprey buildfarm member has been failing for a long while