Re: Error in recent pg_dump change (coverity) - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: Error in recent pg_dump change (coverity)
Date
Msg-id 20060528160111.GB22869@svana.org
Whole thread Raw
In response to Re: Error in recent pg_dump change (coverity)  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Sun, May 28, 2006 at 11:42:48AM -0400, Alvaro Herrera wrote:
> Martijn van Oosterhout wrote:
> > I'd actually suggest zeroing out res->tuples in PQclear so this sort of
> > problem becomes much more obvious.
>
> Is it worthwhile to zero out the res->block array as well?

Patch is good, but setting block to NULL is a waste of time, it's not
global. And I think res->curBlock is automatically set NULL as result
of the loop...

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Error in recent pg_dump change (coverity)
Next
From: Martijn van Oosterhout
Date:
Subject: Re: Error in recent pg_dump change (coverity)