Re: Win32 fix for pg_dumpall - Mailing list pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >               /*
> >                *    We emulate fgets() behaviour. So if there is no newline
> >                *    at the end, we add one...
> >                */
> > !             if (line[len-1] != '\n')
> >                   strcat(line,"\n");
> >           }
>
> This is untrustworthy if len is zero.  Perhaps
>
>             if (len == 0 || line[len-1] != '\n')
>                 strcat(line,"\n");

Agreed, fixed.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073