Re: Win32 fix for pg_dumpall - Mailing list pgsql-patches

Bruce Momjian <pgman@candle.pha.pa.us> writes:
>               /*
>                *    We emulate fgets() behaviour. So if there is no newline
>                *    at the end, we add one...
>                */
> !             if (line[len-1] != '\n')
>                   strcat(line,"\n");
>           }

This is untrustworthy if len is zero.  Perhaps

            if (len == 0 || line[len-1] != '\n')
                strcat(line,"\n");

            regards, tom lane