Re: [pgsql-hackers-win32] Re : Win32 binaries test / pg_dump - Mailing list pgsql-patches

OK, thanks, adjusted, and I added a comment about control-z handling.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > + #ifndef WIN32
> > + #define R_TEXTFILE    "r"
> > + #else
> > + #define R_TEXTFILE    "rb"
> > + #endif
>
> This appears to be redundant with
>
> #if defined(__CYGWIN__) || defined(WIN32)
> #define PG_BINARY       O_BINARY
> #define PG_BINARY_R "rb"
> #define PG_BINARY_W "wb"
> #else
> #define PG_BINARY       0
> #define PG_BINARY_R "r"
> #define PG_BINARY_W "w"
> #endif
>
> in c.h.
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073