Re: Feature request: smarter use of conditional indexes - Mailing list pgsql-performance

From Bruce Momjian
Subject Re: Feature request: smarter use of conditional indexes
Date
Msg-id 200403081755.i28Htau25541@candle.pha.pa.us
Whole thread Raw
In response to Re: Feature request: smarter use of conditional indexes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-performance
Tom Lane wrote:
> Larry Rosenman <ler@lerctr.org> writes:
> > Just a suggestion, please use diff -c format, as it makes it easier for
> > the folks who apply the patches to do so.
>
> That's not just a suggestion ... patches that aren't in diff -c (or at
> least diff -u) format will be rejected out of hand.  Without the context
> lines provided by these formats, applying a patch is an exercise in
> risk-taking, because you can't be certain that you are applying the same
> patch the submitter intended.

Also, when you get 'fuzz' output when applying the patch, you should
review the patch to make sure it appeared in the right place.  That has
gotten me a few times.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-performance by date:

Previous
From: William Yu
Date:
Subject: Re: Scaling further up
Next
From: "Chris Smith"
Date:
Subject: Re: simple query join