Re: fork/exec patch: pre-CreateProcess finalization - Mailing list pgsql-patches

Tom Lane wrote:
> Jan Wieck <JanWieck@Yahoo.com> writes:
> > Something after 2003/11/20 enhanced the query cancel handling. Namely,
> > CVS tip now responds to a query cancel with a postmaster restart
> > canceling all queries. Could the fork/exec stuff be responsible for this?
>
> Whoever changed this:
>
>     status = ProcessStartupPacket(port, false);
>
>     if (status != STATUS_OK)
>         return 0;                /* cancel request processed, or error */
>
> to this:
>
>     status = ProcessStartupPacket(port, false);
>
>     if (status != STATUS_OK)
>     {
>         ereport(LOG,
>                 (errmsg("connection startup failed")));
>         proc_exit(status);
>     }
>
> is responsible.  May we have an explanation of the thought process,
> if any?

Claudio specified the attached fix, which I have applied.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073