Use of 'cp -r' in CREATE DATABASE - Mailing list pgsql-hackers

From Bruce Momjian
Subject Use of 'cp -r' in CREATE DATABASE
Date
Msg-id 200312112336.hBBNa5Y16507@candle.pha.pa.us
Whole thread Raw
Responses Re: Use of 'cp -r' in CREATE DATABASE  (Alvaro Herrera <alvherre@dcc.uchile.cl>)
Re: Use of 'cp -r' in CREATE DATABASE  (Philip Yarra <philip@utiba.com>)
Re: Use of 'cp -r' in CREATE DATABASE  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Our dbcommands.c has for create database:
   snprintf(buf, sizeof(buf), "cp -r '%s' '%s'", src_loc, target_dir);

but my BSD/OS manual only documents 'cp -R' and mentions:
    Historic versions of the cp utility had a -r option.  This implementation    supports that option, however, its use
isstrongly discouraged, as it    does not correctly copy special files, symbolic links or fifo's.
 

I think we should switch to -R in our code.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Alvaro Herrera Munoz
Date:
Subject: Re: [COMMITTERS] pgsql-server/src/bin/initdb nls.mk po/it.po
Next
From: Andrew Dunstan
Date:
Subject: Re: pljava revisited