Re: Use of 'cp -r' in CREATE DATABASE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Use of 'cp -r' in CREATE DATABASE
Date
Msg-id 19678.1071241107@sss.pgh.pa.us
Whole thread Raw
In response to Use of 'cp -r' in CREATE DATABASE  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Use of 'cp -r' in CREATE DATABASE  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> but my BSD/OS manual only documents 'cp -R' and mentions:
> I think we should switch to -R in our code.

And break the code on who knows how many other systems?  No thanks.

If we want to do anything at all with this code, we should eliminate the
use of system("cp") entirely in favor of doing the recursive copy logic
ourselves.  We already have the beginnings of same in the Windows port,
and I think we'll be forced down that path anyway for tablespaces.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Zeugswetter Andreas SB SD"
Date:
Subject: Re: fsync method checking
Next
From: Bruce Momjian
Date:
Subject: Re: pljava revisited