Re: [PATCHES] Proposed GUC Variable - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] Proposed GUC Variable
Date
Msg-id 200208281911.g7SJB9M04913@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCHES] Proposed GUC Variable  (Larry Rosenman <ler@lerctr.org>)
List pgsql-hackers
Larry Rosenman wrote:
> > > 3. Not sure what the "original" is for -- you're not transforming
> > > anything.
> >
> > Agreed.  Just call it "Error query".  Seems clear to me.
> What about rule(s) transformation(s)?  Will we see the real query or the
> transformed query?

Well, looking at Gavin's patch, I see:

+               if(lev == ERROR && Debug_print_error_query)
+                       elog(LOG,"original query: %s",debug_query_string);

That will be the query supplied by the user.  To give them anything else
would be even more confusing --- "How did that query get executed.  I
don't even see that query in my code".  At least when they see that the
query and the error don't match, they can think, rules/triggers, etc.
We should mention the possible mismatch in the docs.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-hackers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: [PATCHES] Proposed GUC Variable
Next
From: Neil Conway
Date:
Subject: Re: @(#)Mordre Labs advisory 0x0005: Several buffer overruns in PostgreSQL