On Wed, 2002-08-28 at 14:05, Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > Gavin Sherry writes:
> >
> > > Attached is the patch. debug_print_error_query is set to false by default.
> > >
> > > For want of a better phrase, I've prepended 'original query: ' to the
> > > error message to highlight why it is in the log.
> >
> > >From your resident How-To-Name-Stuff Nitpicker:
> >
> > 1. The names of the debug_* GUC variables are leftovers from the pre-GUC
> > era and the names where left to include "debug" in them because at the
> > time it wasn't clear whether the implementation had more than server-code
> > debugging quality. New variables should be named log_*.
>
> Agreed. They are not really _debug_ for the server, but debug for user
> apps; should be "log".
>
>
> > 2. Unless you are only logging queries, the correct term is "statement" or
> > "commmand". Statements are defined in the SQL standard to end at the
> > semicolon, but if you're logging whatever the client passed in (which may
> > contain multiple statements) then "command" might be best. (consequently:
> > log_command_on_error or something like that)
>
> Or log_statement_on_error. I think statement is better because we are
> using that now for statement_timeout.
>
> > 3. Not sure what the "original" is for -- you're not transforming
> > anything.
>
> Agreed. Just call it "Error query". Seems clear to me.
What about rule(s) transformation(s)? Will we see the real query or the
transformed query?
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 972-414-9812 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749
