Re: build fixes - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: build fixes
Date
Msg-id 200108211447.f7LElf429676@candle.pha.pa.us
Whole thread Raw
In response to build fixes  (Liam Stewart <liams@redhat.com>)
Responses Re: build fixes  (Liam Stewart <liams@redhat.com>)
List pgsql-patches
>
> Here is a patch that fixes a couple of dumb bugs that cause builds to
> fail.
>
> Liam
>
> --
> Liam Stewart :: Red Hat Canada, Ltd. :: liams@redhat.com

OK, I fixed the first one with:

        snprintf(PQerrormsg, PQERRORMSG_LENGTH,
             "ident_unix: unknown local user with uid %d\n", peercred.uid);
                                                           ^^^^^^^^^^^^^^^

I missed that one because I don't have SO_PEERCRED here.

In the following patch, is it correct to make ECPGd_cardinality = 1 or
should it be put at the end of the list?


Index: src/interfaces/ecpg/include/ecpgtype.h
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/interfaces/ecpg/include/ecpgtype.h,v
retrieving revision 1.18
diff -c -r1.18 ecpgtype.h
*** src/interfaces/ecpg/include/ecpgtype.h    2001/03/29 09:59:00    1.18
--- src/interfaces/ecpg/include/ecpgtype.h    2001/08/21 13:54:47
***************
*** 52,58 ****
      /* descriptor items */
      enum ECPGdtype
      {
!         ECPGd_count = 1,
          ECPGd_data,
          ECPGd_di_code,
          ECPGd_di_precision,
--- 52,59 ----
      /* descriptor items */
      enum ECPGdtype
      {
!         ECPGd_cardinality = 1,
!         ECPGd_count,
          ECPGd_data,
          ECPGd_di_code,
          ECPGd_di_precision,

--yrj/dFKFPuw6o+aM
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0


---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://www.postgresql.org/search.mpl

--yrj/dFKFPuw6o+aM--


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [Fwd: Re: New EXPLAIN ANALYZE statement]
Next
From: Martijn van Oosterhout
Date:
Subject: Re: [Fwd: Re: New EXPLAIN ANALYZE statement]