> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I always rip that stuff out. We do an initdb for every release. What
> > could break by renumbering those nodes?
>
> Actually, since we don't store node type numbers on disk (just symbolic
> names), there's probably nothing that could break as long as people do a
> full recompile when they update. It's no worse than changing the fields
> of a widely-used struct, I suppose. I was just being paranoid.
>
> If you want to apply the patch as-is then you might as well remove all
> the "XXX"'d items in nodes.h...
OK, patch applied, and I applied the following additional patch to
remove two XXX entries in nodes.h.
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Index: nodes.h
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/include/nodes/nodes.h,v
retrieving revision 1.92
diff -c -r1.92 nodes.h
*** nodes.h 2001/07/16 19:07:40 1.92
--- nodes.h 2001/07/16 19:12:33
***************
*** 164,170 ****
T_RemoveAggrStmt,
T_RemoveFuncStmt,
T_RemoveOperStmt,
- T_RemoveStmt_XXX, /* not used anymore; tag# available */
T_RenameStmt,
T_RuleStmt,
T_NotifyStmt,
--- 164,169 ----
***************
*** 221,227 ****
T_BooleanTest,
T_CaseExpr,
T_CaseWhen,
- T_RowMarkXXX, /* not used anymore; tag# available */
T_FkConstraint,
T_PrivGrantee,
--- 220,225 ----
