Re: Removal of temp tables - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Removal of temp tables
Date
Msg-id 200106141753.f5EHro213955@candle.pha.pa.us
Whole thread Raw
In response to Re: Removal of temp tables  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Removal of temp tables  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I was wondering that.  The old vacuum file detection patch had the sort
> > files going into /pg_sorttemp and files called pid_.  Your changes made
> > it pg_tempfile directory and pg_temp file names.  I like the older names
> > that made them clear they were _not_ temp tables.  Seemed you wanted
> > them to have similar names for reasons I couldn't figure.
>
> I'm not wedded to those names; if you have a better idea, let's hear it.
> I changed it because I didn't like the use of the word "sort"; temp
> files are not used only for sorts, but for several other things, and so
> I wanted to see them called temp files not sorttemp files.  But if you
> want to change them so that they look even less like the logical names
> of temp relations, that's OK with me.

OK, I will do that.  What else do we do with them except sorts?  Seems
pid_ was a good file name because they are always based on pid in
storage/file/fd.c.  The directory could be called simply 'tempfile' with
no pg_.  How is that?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Stephen Ramsey
Date:
Subject: possible patch to increase number of hash overflow pages?
Next
From: Tom Lane
Date:
Subject: Re: Removal of temp tables