Re: Cygwin PostgreSQL Python Module Patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Cygwin PostgreSQL Python Module Patch
Date
Msg-id 200105251534.f4PFYRx24781@candle.pha.pa.us
Whole thread Raw
In response to Cygwin PostgreSQL Python Module Patch  (Jason Tishler <Jason.Tishler@dothill.com>)
List pgsql-patches
Patch applied.  Thanks.

> See attached for a minor patch that enables the PostgreSQL Python Module
> to build cleanly under Cygwin.
>
> Thanks,
> Jason
>
>
> --
> Jason Tishler
> Director, Software Engineering       Phone: +1 (732) 264-8770 x235
> Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
> 82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
> Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

-- Start of included mail From: Jason Tishler <Jason.Tishler@dothill.com>

> Date: Fri, 11 May 2001 11:26:13 -0400
> To: Ernesto Revilla <aerd@retemail.es>
> cc: pgsql-cygwin@postgresql.org, cygwin@sources.redhat.com
> bcc: jt+misc.copy@ny.dothill.com
> Subject: Re: Perl + Python Postgresql 7.1.1 under Cygwin
> Mail-Followup-To: Ernesto Revilla <aerd@retemail.es>,
>     pgsql-cygwin@postgresql.org, cygwin@sources.redhat.com
> Content-Disposition: inline
> User-Agent: Mutt/1.3.18i
> Organization: Dot Hill Systems Corp.

> Erny,
>
> On Fri, May 11, 2001 at 01:21:07AM +0200, Ernesto Revilla wrote:
> > For the Python interface to compile, I had to add the -DMS_WIN32 in the
> > Makefile.pre.in . If not a 'not constant type' happens in pgmodule.c line
> > 951.  I don't know if there is a better place tu put the def. After this it
> > compiles and seems to work well. I used Python 2.1.
>
> While changing Cygwin Python to build its core as a DLL (like Win32
> Python) to support shared extension modules, I have learned that Guido
> prefers the style of the attached patch to solve the above problem.
> I feel that this solution is particularly appropriate in this case
> because the following:
>
>     PglargeType
>     PgType
>     PgQueryType
>
> are already being handled in the way that I am proposing for PgSourceType.
>
> I will submit this patch to pgsql-patches for consideration.
>
> Jason
>
> --
> Jason Tishler
> Director, Software Engineering       Phone: +1 (732) 264-8770 x235
> Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
> 82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
> Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

[ Attachment, skipping... ]
-- End of included mail.

>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Jason Tishler
Date:
Subject: Re: Python (PyGreSQL) make install patch
Next
From: Bruce Momjian
Date:
Subject: Re: Python (PyGreSQL) make install patch