Cygwin PostgreSQL Python Module Patch - Mailing list pgsql-patches

From Jason Tishler
Subject Cygwin PostgreSQL Python Module Patch
Date
Msg-id 20010511113030.B421@dothill.com
Whole thread Raw
Responses Re: Cygwin PostgreSQL Python Module Patch  (Jason Tishler <Jason.Tishler@dothill.com>)
Re: Cygwin PostgreSQL Python Module Patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Cygwin PostgreSQL Python Module Patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
See attached for a minor patch that enables the PostgreSQL Python Module
to build cleanly under Cygwin.

Thanks,
Jason


--
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com
Erny,

On Fri, May 11, 2001 at 01:21:07AM +0200, Ernesto Revilla wrote:
> For the Python interface to compile, I had to add the -DMS_WIN32 in the
> Makefile.pre.in . If not a 'not constant type' happens in pgmodule.c line
> 951.  I don't know if there is a better place tu put the def. After this it
> compiles and seems to work well. I used Python 2.1.

While changing Cygwin Python to build its core as a DLL (like Win32
Python) to support shared extension modules, I have learned that Guido
prefers the style of the attached patch to solve the above problem.
I feel that this solution is particularly appropriate in this case
because the following:

    PglargeType
    PgType
    PgQueryType

are already being handled in the way that I am proposing for PgSourceType.

I will submit this patch to pgsql-patches for consideration.

Jason

--
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason.Tishler@dothill.com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

Attachment

pgsql-patches by date:

Previous
From: Ashley Clark
Date:
Subject: Re: [GENERAL] Strange notices, should I worry?
Next
From: Peter Eisentraut
Date:
Subject: Re: Changes needed to build on NetBSD