Re: Cleanup of ODBC - Mailing list pgsql-odbc

From Bruce Momjian
Subject Re: Cleanup of ODBC
Date
Msg-id 200103281607.LAA24186@candle.pha.pa.us
Whole thread Raw
In response to Re: Cleanup of ODBC  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Cleanup of ODBC  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [PATCHES] Re: Cleanup of ODBC  (The Hermit Hacker <scrappy@hub.org>)
List pgsql-odbc
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I am working to clean up the comments in ODBC, and remove some blank
> > lines that make no sense being there.  This will not affect the code in
> > any way.  I should commit in a few hours.
>
> Is it really appropriate to be doing this sort of work post-RC1?
> I see no gain and a nontrivial risk that you will break something
> without knowing it (and without providing adequate time to test it).
>
> It's bad enough to be running pgindent at this late stage of the cycle,
> but at least pgindent is automated and relatively unlikely to make
> errors.  Massive hand edits are another story.
>
> In short: save it for 7.2.

OK, but will people complain if I make comment changes in 7.2 and mess
up their patches and the 7.1 patches people submit?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-odbc by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Cleanup of ODBC
Next
From: Tom Lane
Date:
Subject: Re: Cleanup of ODBC