Re: [ODBC] Cleanup of ODBC - Mailing list pgsql-patches

From Tom Lane
Subject Re: [ODBC] Cleanup of ODBC
Date
Msg-id 18261.985795586@sss.pgh.pa.us
Whole thread Raw
In response to Cleanup of ODBC  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [ODBC] Cleanup of ODBC
Re: Re: [ODBC] Cleanup of ODBC
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I am working to clean up the comments in ODBC, and remove some blank
> lines that make no sense being there.  This will not affect the code in
> any way.  I should commit in a few hours.

Is it really appropriate to be doing this sort of work post-RC1?
I see no gain and a nontrivial risk that you will break something
without knowing it (and without providing adequate time to test it).

It's bad enough to be running pgindent at this late stage of the cycle,
but at least pgindent is automated and relatively unlikely to make
errors.  Massive hand edits are another story.

In short: save it for 7.2.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Cleanup of ODBC
Next
From: Bruce Momjian
Date:
Subject: Re: [ODBC] Cleanup of ODBC