Re: ODBC Patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: ODBC Patch
Date
Msg-id 200102121411.JAA21633@candle.pha.pa.us
Whole thread Raw
In response to RE: ODBC Patch  (Dave Page <dpage@vale-housing.co.uk>)
Responses Re: ODBC Patch
List pgsql-patches
> > Dave, can you test the attached patch?  I assume the problem was that
> > pgindent does not recognize // as comments, and in fact, we don't want
> > to use them.
> >
> > This should fix the problem.
>
> I've not tested it (I'm just configuring my new laptop :-) ) but that should
> work (and has done - if you look back in CVS I made that mod before). The
> problem is that MS VC++ autogenerates resource.h whenever psqlodbc.rc is
> updated in the IDE. Is it possible to get pgindent to ignore that file or
> would that cause more problems?

Sure, we can ignore it, but do we want an MS-generated file to be
tracked in our CVS, and especially one with // comments?

If resource.h was included only by MS compilers, that would be better,
but I see every platform including the file.

Can you send me that resource.h file again, and I will merge in any
change made by *.rc, but keep the /* */ comments, OK?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Dave Page
Date:
Subject: RE: ODBC Patch
Next
From: Tom Lane
Date:
Subject: Re: ODBC Patch