Re: Update: mac.c update, patch now on ftp - Mailing list pgsql-hackers

From Larry Rosenman
Subject Re: Update: mac.c update, patch now on ftp
Date
Msg-id 200007180155.e6I1teX02126@lerami.lerctr.org
Whole thread Raw
In response to Re: Update: mac.c update, patch now on ftp  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I just don't have the smarts to do the code for the backend. 

(strange thought:include my ouiparse.awk (changed to generate SQL inserts), anddoes macaddr support like xx:xx:xx%
lookups?if so, give themthe tool to make their own DB.). 
 
The code in mac.c does a LINEAR search, and the list is only going togrow.  It's at 4110+ OUI's that are PUBLIC.). 
Larry
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> In looking at this patch, it changes mac.c from:
> >> 
> >> 8513 mac.c
> >> 184323 mac.c.new
> 
> Yipes.
> 
> >> This seems like a major size increase.  Is it worth it to get
> >> card manufacturers?
> 
> > Given that our list is old, and the new list is large, does anyone
> > really want this feature.  It allows the lookup of an ethernet card
> > manufacturer based on the ethernet MAC address.
> 
> Seems like hardwiring the lookup table in the server code is
> fundamentally wrongheaded anyway.  It should have been designed as
> (wait for it...) a database table lookup.
> 
> I'd suggest maybe this feature should be offered as a contrib item
> containing a database table dump and a simple lookup function
> coded in SQL.  Lots easier to maintain, and it doesn't bloat the
> backend for people who don't need it.
> 
>             regards, tom lane


-- 
Larry Rosenman                      http://www.lerctr.org/~ler
Phone: +1 972-414-9812 (voice) Internet: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749


pgsql-hackers by date:

Previous
From: Philip Warner
Date:
Subject: Re: Should PG backend know how to represent metadata?
Next
From: Thomas Lockhart
Date:
Subject: Re: Update: mac.c update, patch now on ftp