Re: invalid data in file backup_label problem on windows - Mailing list pgsql-hackers

From David Steele
Subject Re: invalid data in file backup_label problem on windows
Date
Msg-id 1fe0e5cd-ddfc-8c2e-3967-ed92535ae717@pgmasters.net
Whole thread Raw
In response to Re: invalid data in file backup_label problem on windows  (Magnus Hagander <magnus@hagander.net>)
Responses RE: invalid data in file backup_label problem on windows  ("wangsh.fnst@fujitsu.com" <wangsh.fnst@fujitsu.com>)
Re: invalid data in file backup_label problem on windows  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 3/26/21 1:20 PM, Magnus Hagander wrote:
> On Fri, Mar 26, 2021 at 5:52 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>> On 3/26/21 10:19 AM, David Steele wrote:
>>>
>>>> No, the problem is you are using copy/paste and in doing so you are
>>>> *changing'* the value that is being returned. You'll either need to
>>>> update your copy/paste procedure to not mess with the newlines, or to
>>>> use a better way to get the data out.
>>>>
>>>> If we need to clarify that in the documentation, I'm fine with that.
>>>> Maybe add an extra sentence to the part about not modifying the output
>>>> to mention that this includes changing newslines and also encoding
>>>> (which would also break it, if you managed to find a non-ascii
>>>> compatible encoding). Maybe even something along the line of "the
>>>> contents have to be written in binary mode"?
>>>
>>> Perhaps something like the attached?
>>
>> That seems a bit opaque.  Let's tell them exactly what they need to avoid.
> 
> Yeah, it seems a bit imprecise. Maybe something like "which includes
> things like opening the file in binary mode"? (I want the "includes"
> part because it also means other things, this is not the only thing).

OK, how about the attached?

Regards,
-- 
-David
david@pgmasters.net

Attachment

pgsql-hackers by date:

Previous
From: legrand legrand
Date:
Subject: Re: Query about pg asynchronous processing support
Next
From: Sven Klemm
Date:
Subject: [PATCH] Allow CustomScan nodes to signal projection support