Re: invalid data in file backup_label problem on windows - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: invalid data in file backup_label problem on windows
Date
Msg-id CABUevEwy1-9tH0FUa_C6+ffaBu+wwAsdjRh45v_kJP-=OPYd1g@mail.gmail.com
Whole thread Raw
In response to Re: invalid data in file backup_label problem on windows  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: invalid data in file backup_label problem on windows  (David Steele <david@pgmasters.net>)
List pgsql-hackers
On Fri, Mar 26, 2021 at 5:52 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 3/26/21 10:19 AM, David Steele wrote:
> >
> >> No, the problem is you are using copy/paste and in doing so you are
> >> *changing'* the value that is being returned. You'll either need to
> >> update your copy/paste procedure to not mess with the newlines, or to
> >> use a better way to get the data out.
> >>
> >> If we need to clarify that in the documentation, I'm fine with that.
> >> Maybe add an extra sentence to the part about not modifying the output
> >> to mention that this includes changing newslines and also encoding
> >> (which would also break it, if you managed to find a non-ascii
> >> compatible encoding). Maybe even something along the line of "the
> >> contents have to be written in binary mode"?
> >
> > Perhaps something like the attached?
> >
> >
>
>
> That seems a bit opaque.  Let's tell them exactly what they need to avoid.

Yeah, it seems a bit imprecise. Maybe something like "which includes
things like opening the file in binary mode"? (I want the "includes"
part because it also means other things, this is not the only thing).

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Walsender may fail to send wal to the end.
Next
From: "Daniel Verite"
Date:
Subject: Re: Calendar support in localization