Re: Make tuple deformation faster - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: Make tuple deformation faster
Date
Msg-id 1d5805cd960c15e076405e91099d77f8e42066d5.camel@j-davis.com
Whole thread Raw
In response to Make tuple deformation faster  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Make tuple deformation faster
List pgsql-hackers
On Thu, 2024-10-10 at 02:59 +1300, David Rowley wrote:
> > A few weeks ago David and I discussed this patch. We were curious
> > *why* the
> > flags approach was slower.

...

> > Could it make sense to use bitfields instead of flag values, to
> > reduce the
> > impact?
>
> Yeah. That's a good idea.

I happened to run into the code and was surprised to see a strongly-
worded comment about the size of CompactAttribute, but then also see
independent booleans rather than flags or bitfields.

Did the discussion end here, or was there some kind of conclusion? Is
it worth adding a comment about why we use independent booleans, even
if we don't have a complete answer?

Regards,
    Jeff Davis




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Rename some signal and interrupt handling functions for consistency
Next
From: Tomas Vondra
Date:
Subject: Re: Parallel CREATE INDEX for GIN indexes