Re: [BUGS] BUG #14706: Dependencies not recorded properly for basetypes - Mailing list pgsql-bugs

From Heikki Linnakangas
Subject Re: [BUGS] BUG #14706: Dependencies not recorded properly for basetypes
Date
Msg-id 1c07c9a6-b56f-fe67-63a5-6913e78df1f6@iki.fi
Whole thread Raw
In response to Re: [BUGS] BUG #14706: Dependencies not recorded properly for base types  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [BUGS] BUG #14706: Dependencies not recorded properly for base types  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs
On 06/15/2017 07:31 PM, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Hmm. Strictly speaking there's no need to update the dependency when
>> changing opaque into cstring. Because cstring is a pinned type,
>> recordDependency will do nothing for it.
>
>> But in any case, I think it'd be better and simpler to fix the
>> dependency in SetFunctionArgType() and SetFunctionReturnType() functions
>> themselves. They're the ones that change the type, they ought to be
>> responsible for fixing the dependency too. See attached.
>
> Yeah, Heikki's version looks good to me.
>
> Heikki, are you going to commit/backpatch this, or do you want me to?

I can do it, thanks.

- Heikki



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: [BUGS] BUG #14706: Dependencies not recorded properly for base types
Next
From: mark.manley@tapad.com
Date:
Subject: [BUGS] BUG #14709: inconsistent answers with foreign data wrappers to mysql