Re: [BUGS] BUG #14706: Dependencies not recorded properly for base types - Mailing list pgsql-bugs

From Tom Lane
Subject Re: [BUGS] BUG #14706: Dependencies not recorded properly for base types
Date
Msg-id 11135.1497544300@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #14706: Dependencies not recorded properly for basetypes  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: [BUGS] BUG #14706: Dependencies not recorded properly for basetypes  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-bugs
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> Hmm. Strictly speaking there's no need to update the dependency when 
> changing opaque into cstring. Because cstring is a pinned type, 
> recordDependency will do nothing for it.

> But in any case, I think it'd be better and simpler to fix the 
> dependency in SetFunctionArgType() and SetFunctionReturnType() functions 
> themselves. They're the ones that change the type, they ought to be 
> responsible for fixing the dependency too. See attached.

Yeah, Heikki's version looks good to me.

Heikki, are you going to commit/backpatch this, or do you want me to?
        regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: 厚积薄发
Date:
Subject: [BUGS] GIN index vacuum hang after pg_rman restore in PG9.2.21
Next
From: Heikki Linnakangas
Date:
Subject: Re: [BUGS] BUG #14706: Dependencies not recorded properly for basetypes