Re: pgindent vs. git whitespace check - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pgindent vs. git whitespace check
Date
Msg-id 1F36DFB5-0B3C-413F-B125-35B6E1BC3F20@yesql.se
Whole thread Raw
In response to Re: pgindent vs. git whitespace check  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pgindent vs. git whitespace check  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
> On 29 Mar 2023, at 19:18, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Feb 23, 2023 at 09:36:00AM +0100, Daniel Gustafsson wrote:
>>> On 23 Feb 2023, at 05:48, Tom Lane <tgl@sss.pgh.pa.us> wrote:

>>> Mass conversion of /* to // style would answer that,
>>> but would also create an impossible back-patching problem.
>>
>> Yeah, that sounds incredibly invasive.
>
> I am replying late here but ...
>
> We would have to convert all supported branches, and tell all forks to
> do the same (hopefully at the same time).  The new standard would then
> be for all single-line comments to use // instead of /* ... */.

That still leaves every patch which is in flight on -hackers, and conflicts in
local development trees etc.  It's doable (apart from forks, but that cannot be
our core concern), but I personally can't see the price paid justify the result.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: SQL/JSON revisited
Next
From: Peter Geoghegan
Date:
Subject: Re: Add pg_walinspect function with block info columns