Re: [HACKERS] indexable and locale - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] indexable and locale
Date
Msg-id 199911300151.UAA20842@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] indexable and locale  (Tatsuo Ishii <t-ishii@sra.co.jp>)
List pgsql-hackers
> > Hello again,
> > I thought I should start making some small contibutions before 7.0.
> > 
> > Attached is a patch to the old problem discussed feverly before 6.5.
> > What is does:
> > for locale-enabled servers: 
> >     use index if last char before '%' is ascii.
> > for non-locale servers: 
> >     do not use locale if last char is non-ascii since it is wrong anyway.
> > 
> > Comments?         
> 
> I tried your patches but it seems malformed:
> 
>     patch: **** unexpected end of file in patch


Yes, I had to apply it manually.

> So this is a guess from reading them. I think your pacthes break
> non-ascii multi-byte character sets data and should be surrounded by
> #ifdef LOCALE rather than replacing current codes surrounded by
> #ifndef LOCALE.

Can you supply a patch against the current tree?  I don't understand
this. Thanks.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tim Holloway
Date:
Subject: Re: [HACKERS] How to get info about deadlocks?
Next
From: Bruce Momjian
Date:
Subject: Re: indexable and locale