Re: [HACKERS] Current source from CVS won't compile. - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Current source from CVS won't compile.
Date
Msg-id 199910261738.NAA28034@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Current source from CVS won't compile.  (Mike Mascari <mascarim@yahoo.com>)
List pgsql-hackers
> > Can we use only NULL, and not '' please?  Seems clearer.  I don't like
> > us of '' for any special handling.  Thanks.
> > 
> > -- 
> >   Bruce Momjian                        |  http://www.op.net/~candle
> >   maillist@candle.pha.pa.us            |  (610) 853-3000
> >   +  If your life is a hard drive,     |  830 Blythe Avenue
> >   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania
> > 19026
> > 
> 
> I agree with you, an empty string is a goofy way to drop a comment.
> The only reason I did it that way was because that's how Oracle does
> it (heck, why not create comment on, drop comment on). The question is,
> what should the behavior be when a user supplies an empty string?
> 
> COMMENT ON TABLE employees IS '';
> 
> Should the above add an empty comment to pg_description?

OK, I like the compatability issue.  Let's leave both as dropping
comments, but only document the NULL case.  SGML already updated.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Function-manager redesign: second draft (long)
Next
From: Tim Holloway
Date:
Subject: Re: [HACKERS] Logging - pg_options format change?