Re: [PORTS] Port Bug Report: int2 negative numbers not parsed correctly - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PORTS] Port Bug Report: int2 negative numbers not parsed correctly
Date
Msg-id 199804011602.LAA19457@candle.pha.pa.us
Whole thread Raw
In response to Re: [PORTS] Port Bug Report: int2 negative numbers not parsed correctly  ("Thomas G. Lockhart" <lockhart@alumni.caltech.edu>)
List pgsql-hackers
>
> > I am confused.  As I can tell, these are coming in as null_expr - 1.
>
> What is "null_expr - 1"? I think that is the same thing; a node with a
> subtraction operator and the left side set to null and the right side
> set to a constant node. That's what I meant by the unary minus on a
> constant.
>
> > Why can't we do a check in gram.y,...
>
> Well we maybe can, but it sure is ugly. This will be spread around a
> bunch of places (everywhere there is a unary minus allowed). I already
> did the wrong thing and brute-forced something similar into the CREATE
> SEQUENCE code in gram.y. Isolating it in transform_expr() or somewhere
> like that would be much cleaner.
>

But isn't it is just one line in gram.y.  That is where I was seeing it
happen.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: "Jose' Soares Da Silva"
Date:
Subject: Re: [HACKERS] Re: [DOCS] Reference Manual
Next
From: "Thomas G. Lockhart"
Date:
Subject: Re: [HACKERS] Re: [DOCS] Reference Manual