Re: Show various offset arrays for heap WAL records - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Show various offset arrays for heap WAL records
Date
Msg-id 197fca5f-669b-ed76-6cc5-1dd81e63fa13@enterprisedb.com
Whole thread Raw
In response to Re: Show various offset arrays for heap WAL records  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On 01.03.23 17:11, Melanie Plageman wrote:
> diff --git a/contrib/pg_walinspect/pg_walinspect--1.0.sql b/contrib/pg_walinspect/pg_walinspect--1.0.sql
> index 08b3dd5556..eb8ff82dd8 100644
> --- a/contrib/pg_walinspect/pg_walinspect--1.0.sql
> +++ b/contrib/pg_walinspect/pg_walinspect--1.0.sql
> @@ -17,7 +17,7 @@ CREATE FUNCTION pg_get_wal_record_info(IN in_lsn pg_lsn,
>       OUT main_data_length int4,
>       OUT fpi_length int4,
>       OUT description text,
> -    OUT block_ref text
> +    OUT block_ref int4[][]
>   )
>   AS 'MODULE_PATHNAME', 'pg_get_wal_record_info'
>   LANGUAGE C STRICT PARALLEL SAFE;

A change like this would require a new extension version and an upgrade 
script.

I suppose it's ok to postpone that work while the actual meat of the 
patch is still being worked out, but I figured I'd mention it in case it 
wasn't considered yet.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Timeline ID hexadecimal format
Next
From: Peter Eisentraut
Date:
Subject: Re: Make some xlogreader messages more accurate