Re: Make some xlogreader messages more accurate - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Make some xlogreader messages more accurate
Date
Msg-id 29eab0fe-5edb-5837-493b-73398844fa07@enterprisedb.com
Whole thread Raw
In response to Re: Make some xlogreader messages more accurate  (Jeevan Ladhe <jeevanladhe.os@gmail.com>)
List pgsql-hackers
On 28.02.23 11:19, Jeevan Ladhe wrote:
> +1 for the changes.
> 
>  >1. Why is "wanted >=%u" any better than "wanted at least %u"? IMO, the
>  >wording as opposed to >= symbol in the user-facing messages works
>  >better.
> 
> I think I agree with Bharath on this: "wanted at least %u" sounds better
> for user error than "wanted >=%u".

I committed this with "at least", as suggested, and also changed 
"wanted" to "expected", which matches the usual error message style better.




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Show various offset arrays for heap WAL records
Next
From: Peter Eisentraut
Date:
Subject: Re: Make some xlogreader messages more accurate