Re: tiny fix needed - Mailing list pgsql-hackers

From Tom Lane
Subject Re: tiny fix needed
Date
Msg-id 1944.1164598186@sss.pgh.pa.us
Whole thread Raw
In response to tiny fix needed  ("Andrew Dunstan" <andrew@dunslane.net>)
Responses Re: tiny fix needed  ("Andrew Dunstan" <andrew@dunslane.net>)
List pgsql-hackers
"Andrew Dunstan" <andrew@dunslane.net> writes:
> I have just discovered a tiny fix that is needed when compiling on Windows
> with a very late model libintl.h. Essentially we need to add vfprintf to
> the list of items we stop the libintl headers from hijacking. I am still
> testing, but this change (3 extra lines in port.h) should be very low
> risk.

Hm, you mean only

#ifdef vfprintf
#undef vfprintf
#endif

This seems a bit strange, because the other functions such as vsnprintf
have several other relevant bits in port.h, plus supporting code in
src/port/ ... why wouldn't we need all of that?
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Andrew Dunstan"
Date:
Subject: tiny fix needed
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Avg performance for int8/numeric