Re: tiny fix needed - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: tiny fix needed
Date
Msg-id 3182.24.211.165.134.1164616882.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: tiny fix needed  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: tiny fix needed  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Tom Lane wrote:
> "Andrew Dunstan" <andrew@dunslane.net> writes:
>> I have just discovered a tiny fix that is needed when compiling on
>> Windows
>> with a very late model libintl.h. Essentially we need to add vfprintf to
>> the list of items we stop the libintl headers from hijacking. I am still
>> testing, but this change (3 extra lines in port.h) should be very low
>> risk.
>
> Hm, you mean only
>
> #ifdef vfprintf
> #undef vfprintf
> #endif
>
> This seems a bit strange, because the other functions such as vsnprintf
> have several other relevant bits in port.h, plus supporting code in
> src/port/ ... why wouldn't we need all of that?
>


*sigh* you could well be right. I will dig some more. It only happens for
ECPG - everything else links just fine.

cheers

andrew



pgsql-hackers by date:

Previous
From: "Jeroen T. Vermeulen"
Date:
Subject: Re: "Optional ident" authentication
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: [CORE] RC1 blocker issues