Re: [HACKERS] pgsql: Refactor flex and bison make rules - Mailing list pgsql-committers

From Tom Lane
Subject Re: [HACKERS] pgsql: Refactor flex and bison make rules
Date
Msg-id 19170.1354144771@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pgsql: Refactor flex and bison make rules  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [HACKERS] pgsql: Refactor flex and bison make rules  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> On 11/28/12 6:01 PM, Tom Lane wrote:
>> I wonder whether adding another .NOTPARALLEL directive would be a better
>> idea than insisting people get hold of patched versions.

> We could put
> ifeq ($(MAKE_VERSION),3.82)
> .NOTPARALLEL:
> endif
> into Makefile.global.

I don't wish to go *that* far.  Parallel make works fine for most of the
tree in 3.82, and shutting it off would penalize developers a lot.

It appears to me that the case that okapi is hitting is specific to the
ecpg preprocessor build rules, and indeed specific to the case where
preproc.c needs to be rebuilt.  A .NOTPARALLEL in ecpg/preproc/Makefile
would probably be enough to fix it.  (I'm a bit tempted to make the one
already added to ecpg/Makefile conditional on the make version, as you
suggest above, too.)

            regards, tom lane


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Refactor flex and bison make rules
Next
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] pgsql: Refactor flex and bison make rules