Re: [HACKERS] pgsql: Refactor flex and bison make rules - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: [HACKERS] pgsql: Refactor flex and bison make rules
Date
Msg-id 50B69E74.5040702@dunslane.net
Whole thread Raw
In response to Re: [HACKERS] pgsql: Refactor flex and bison make rules  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] pgsql: Refactor flex and bison make rules
List pgsql-committers
On 11/28/2012 06:19 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> On 11/28/12 6:01 PM, Tom Lane wrote:
>>> I wonder whether adding another .NOTPARALLEL directive would be a better
>>> idea than insisting people get hold of patched versions.
>> We could put
>> ifeq ($(MAKE_VERSION),3.82)
>> .NOTPARALLEL:
>> endif
>> into Makefile.global.
> I don't wish to go *that* far.  Parallel make works fine for most of the
> tree in 3.82, and shutting it off would penalize developers a lot.
>
> It appears to me that the case that okapi is hitting is specific to the
> ecpg preprocessor build rules, and indeed specific to the case where
> preproc.c needs to be rebuilt.  A .NOTPARALLEL in ecpg/preproc/Makefile
> would probably be enough to fix it.  (I'm a bit tempted to make the one
> already added to ecpg/Makefile conditional on the make version, as you
> suggest above, too.)
>
>


There is something odd about okapi, because my linux/gcc buildfarm
animal is using make 3.82 happily, with make_jobs = 4.

cheers

andrew


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] pgsql: Refactor flex and bison make rules
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] pgsql: Refactor flex and bison make rules