Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Check that we have a working tar before trying to use it - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Check that we have a working tar before trying to use it
Date
Msg-id 190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net
Whole thread Raw
In response to Re: pgsql: Check that we have a working tar before trying to use it  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Check that we have a working tar before trying to use it
List pgsql-committers
Tree view 
On 12/13/21 03:08, Michael Paquier wrote:
> Also,
> the default values of LZ4, TAR and GZIP_PROGRAM had better be set
> *before* loading buildenv.pl, and not after it is loaded, no?  On
> HEAD, one has no way to unset any of those variables so it is not
> possible to skip things if an environment has in its PATH a funky
> command that TAP would refuse, like a tar command from MinGW or the
> git installation.


No. The code only sets them if they have not been previously set by
buildenv.pl or the calling environment. That's what "||=" means.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Suppress -Wformat-overflow warnings in 9.2's xml.c.
Next
From: Tom Lane
Date:
Subject: pgsql: Suppress -Warray-bounds warning in 9.2's xlog.c.