Re: [PATCH] 2PC state files on shared memory - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] 2PC state files on shared memory
Date
Msg-id 18854.1249886722@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] 2PC state files on shared memory  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> After making a lot of tests, state file size is not more than 600B.
> In some cases, it reached a maximum of size of 712B and I used such
> transactions in my tests.

I can only say that that demonstrates you didn't test very many cases.
It is trivial to generate enormous state files --- try something with
a lot of subtransactions, for example, or a lot of files created or
deleted.  I remain of the opinion that asking users to estimate the
amount of shared memory needed for this patch will cripple its
usability.  We learned that lesson the hard way for FSM, I see no
reason we have to fail to learn from experience.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Patch for 8.5, transformationHook
Next
From: "Albe Laurenz"
Date:
Subject: Re: Split-up ECPG patches