Re: pgbench enhancements - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgbench enhancements
Date
Msg-id 1879.1153925882@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgbench enhancements  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: pgbench enhancements  (Tatsuo Ishii <ishii@sraoss.co.jp>)
List pgsql-hackers
Tatsuo Ishii <ishii@sraoss.co.jp> writes:
> BTW, running long benchmark using pgbench on BIG tables easily causes
> an integer overflow error in following SQLs:

Right.

> I'm inclined to change abalance, tbalance and bbalance column to
> BIGINT to avoid the error. Opinion?

No.  The problem is that the deltas are invariably positive, which is
not realistic (at least *my* bank balance isn't uniformly increasing :-().
I think the correct fix is just to tweak the range of the randomly
distributed deltas to be plus and minus not always plus.

If you change to bigint then post-change results won't be strictly
comparable to pre-change results because of the difference in execution
costs.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: Re: [PATCHES] patch implementing the multi-argument aggregates (SOC project)
Next
From: Tom Lane
Date:
Subject: Re: Better name/syntax for "online" index creation