Re: truncating timestamps on arbitrary intervals - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: truncating timestamps on arbitrary intervals
Date
Msg-id 18539c1b-b672-2328-731c-38ee00fdd966@enterprisedb.com
Whole thread Raw
In response to Re: truncating timestamps on arbitrary intervals  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: truncating timestamps on arbitrary intervals  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-hackers
On 30.03.21 18:06, John Naylor wrote:
> Currently, when the origin is after the input, the result is the 
> timestamp at the end of the bin, rather than the beginning as expected. 
> The attached puts the result consistently at the beginning of the bin.

In the patch

+   if (origin > timestamp && stride_usecs > 1)
+       tm_delta -= stride_usecs;

is the condition stride_usecs > 1 really necessary?  My assessment is 
that it's not, in which case it would be better to omit it.



pgsql-hackers by date:

Previous
From: "Daniel Westermann (DWE)"
Date:
Subject: Re: check_function_bodies: At least the description seems wrong, since we have prodedures
Next
From: Amit Kapila
Date:
Subject: Re: Replication slot stats misgivings